From abbfe517de9a29ca2a75b83544695b3bb9b1dc9f Mon Sep 17 00:00:00 2001 From: Fabio Manganiello Date: Tue, 26 Nov 2019 15:52:27 +0100 Subject: [PATCH] Don't override matches_condition in ResponseEvent to run stop_conversation. Use the flag play_response=False on plugin level to bypass the response instead --- platypush/message/event/assistant/__init__.py | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/platypush/message/event/assistant/__init__.py b/platypush/message/event/assistant/__init__.py index 934fcca74..8b0affef0 100644 --- a/platypush/message/event/assistant/__init__.py +++ b/platypush/message/event/assistant/__init__.py @@ -70,18 +70,6 @@ class ResponseEvent(ConversationEndEvent): super().__init__(*args, response_text=response_text, **kwargs) - def matches_condition(self, condition): - """ - Overrides matches condition, and stops the conversation to prevent the - default assistant response if the event matched some event hook condition - """ - - result = super().matches_condition(condition) - if result.is_match and self._assistant: - self._assistant.stop_conversation() - - return result - class NoResponseEvent(ConversationEndEvent): """