From a31606db0d4b4e44cf3ff7f6efc9165ccf27a23e Mon Sep 17 00:00:00 2001 From: Tim Culverhouse Date: Mon, 19 Sep 2022 19:20:31 -0500 Subject: [PATCH] grid: remove unused method Children The grid method Children returns the children of a grid, and is never used. The function is reimplemented in both aerc.go and account.go, also never called. Remove these unused methods. Signed-off-by: Tim Culverhouse Acked-by: Robin Jarry --- lib/ui/grid.go | 11 ----------- widgets/account.go | 4 ---- widgets/aerc.go | 4 ---- 3 files changed, 19 deletions(-) diff --git a/lib/ui/grid.go b/lib/ui/grid.go index 1eac2ee..04a6dc4 100644 --- a/lib/ui/grid.go +++ b/lib/ui/grid.go @@ -94,17 +94,6 @@ func (grid *Grid) Columns(spec []GridSpec) *Grid { return grid } -func (grid *Grid) Children() []Drawable { - grid.mutex.RLock() - defer grid.mutex.RUnlock() - - children := make([]Drawable, len(grid.cells)) - for i, cell := range grid.cells { - children[i] = cell.Content - } - return children -} - func (grid *Grid) Draw(ctx *Context) { invalid := grid.invalid if invalid { diff --git a/widgets/account.go b/widgets/account.go index 6046876..8cac373 100644 --- a/widgets/account.go +++ b/widgets/account.go @@ -155,10 +155,6 @@ func (acct *AccountView) Name() string { return acct.acct.Name } -func (acct *AccountView) Children() []ui.Drawable { - return acct.grid.Children() -} - func (acct *AccountView) OnInvalidate(onInvalidate func(d ui.Drawable)) { acct.grid.OnInvalidate(func(_ ui.Drawable) { onInvalidate(acct) diff --git a/widgets/aerc.go b/widgets/aerc.go index 2b7a6d8..4cd96a8 100644 --- a/widgets/aerc.go +++ b/widgets/aerc.go @@ -167,10 +167,6 @@ func (aerc *Aerc) Tick() bool { return more } -func (aerc *Aerc) Children() []ui.Drawable { - return aerc.grid.Children() -} - func (aerc *Aerc) OnInvalidate(onInvalidate func(d ui.Drawable)) { aerc.grid.OnInvalidate(func(_ ui.Drawable) { onInvalidate(aerc)