From d99b6081f7464e332fbad4e79d6004a8a8698e2f Mon Sep 17 00:00:00 2001 From: Koni Marti Date: Tue, 4 Oct 2022 10:08:19 +0200 Subject: [PATCH] imap: fix flags update Fixes updating the flags in the imap backend. Before, the silent flag was set incorrectly by 75fc42e ("imap: send message info updates for bulk flag ops") which caused some imap servers to not send the updated flags. By disabling the silent flag, the flag update will return a corrsponding value that we can send back to the message store to update the flags correctly. Fixes: 75fc42e ("imap: send message info updates for bulk flag ops") Reported-by: Jens Grassel Signed-off-by: Koni Marti Tested-by: Jens Grassel Acked-by: Robin Jarry --- worker/imap/flags.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/worker/imap/flags.go b/worker/imap/flags.go index ccb8c10..7ff6de3 100644 --- a/worker/imap/flags.go +++ b/worker/imap/flags.go @@ -30,10 +30,10 @@ func (imapw *IMAPWorker) handleDeleteMessages(msg *types.DeleteMessages) { } func (imapw *IMAPWorker) handleAnsweredMessages(msg *types.AnsweredMessages) { - item := imap.FormatFlagsOp(imap.AddFlags, true) + item := imap.FormatFlagsOp(imap.AddFlags, false) flags := []interface{}{imap.AnsweredFlag} if !msg.Answered { - item = imap.FormatFlagsOp(imap.RemoveFlags, true) + item = imap.FormatFlagsOp(imap.RemoveFlags, false) flags = []interface{}{imap.AnsweredFlag} } imapw.handleStoreOps(msg, msg.Uids, item, flags, @@ -51,9 +51,9 @@ func (imapw *IMAPWorker) handleAnsweredMessages(msg *types.AnsweredMessages) { func (imapw *IMAPWorker) handleFlagMessages(msg *types.FlagMessages) { flags := []interface{}{flagToImap[msg.Flag]} - item := imap.FormatFlagsOp(imap.AddFlags, true) + item := imap.FormatFlagsOp(imap.AddFlags, false) if !msg.Enable { - item = imap.FormatFlagsOp(imap.RemoveFlags, true) + item = imap.FormatFlagsOp(imap.RemoveFlags, false) } imapw.handleStoreOps(msg, msg.Uids, item, flags, func(_msg *imap.Message) error {