From 33d4c8342d9165e704b89e5be39668f748eec09a Mon Sep 17 00:00:00 2001 From: Fabio Manganiello Date: Mon, 15 Apr 2024 23:01:10 +0200 Subject: [PATCH] [#389] Possible fix for "Too many open files" media issue. It seems that the process keeps a lot of open connections to Chromecast devices during playback. The most likely culprit is the `_refresh_chromecasts` logic. We should start a `cast` object and register a status listener only if a Chromecast with the same identifier isn't already registered in the plugin. --- platypush/plugins/media/chromecast/__init__.py | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/platypush/plugins/media/chromecast/__init__.py b/platypush/plugins/media/chromecast/__init__.py index 5dc0db73..9afb4357 100644 --- a/platypush/plugins/media/chromecast/__init__.py +++ b/platypush/plugins/media/chromecast/__init__.py @@ -105,7 +105,7 @@ class MediaChromecastPlugin(MediaPlugin, RunnablePlugin): :param callback: If blocking is false, then you can provide a callback function that will be invoked when a new device is discovered """ - self.chromecasts = { + casts = { self._get_device_property(cast, 'friendly_name'): cast for cast in self._get_chromecasts( tries=tries, @@ -116,11 +116,18 @@ class MediaChromecastPlugin(MediaPlugin, RunnablePlugin): ) } - for name, cast in self.chromecasts.items(): - self._update_listeners(name, cast) + for name, cast in casts.copy().items(): + if not self.chromecasts.get(name): + self.logger.info('Discovered new Chromecast: %s', name) + self.chromecasts[name] = cast + self._update_listeners(name, cast) + cast.wait() + else: + casts.pop(name) - for cast in self.chromecasts.values(): + for name, cast in casts.items(): cast.wait() + self.logger.info('Refreshed Chromecast state: %s', name) def _event_callback(self, _, cast: pychromecast.Chromecast): with self._refresh_lock: @@ -133,6 +140,7 @@ class MediaChromecastPlugin(MediaPlugin, RunnablePlugin): name=name, cast=cast, callback=self._event_callback ) cast.media_controller.register_status_listener(self._media_listeners[name]) + self.logger.debug('Started media listener for %s', name) def get_chromecast(self, chromecast=None, n_tries=2): if isinstance(chromecast, pychromecast.Chromecast):