From ceb9d6d1bac525bbcb1d5e7b6c9195f3efa3d1e5 Mon Sep 17 00:00:00 2001 From: Fabio Manganiello Date: Mon, 14 Aug 2023 23:37:38 +0200 Subject: [PATCH] Removed redundant `Backend._get_redis()` method. It was used only once, and it could easily be replaced by `platypush.utils.get_redis()`. --- platypush/backend/__init__.py | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/platypush/backend/__init__.py b/platypush/backend/__init__.py index 1afc4385..92929b77 100644 --- a/platypush/backend/__init__.py +++ b/platypush/backend/__init__.py @@ -27,6 +27,7 @@ from platypush.message import Message from platypush.message.event import Event from platypush.message.request import Request from platypush.message.response import Response +from platypush.utils import get_redis class Backend(Thread, EventGenerator, ExtensionWithManifest): @@ -308,22 +309,6 @@ class Backend(Thread, EventGenerator, ExtensionWithManifest): def wait_stop(self, timeout=None) -> bool: return self._stop_event.wait(timeout) - def _get_redis(self): - import redis - - redis_backend = get_backend('redis') - if not redis_backend: - self.logger.warning( - 'Redis backend not configured - some ' - 'web server features may not be working properly' - ) - redis_args = {} - else: - redis_args = redis_backend.redis_args - - redis = redis.Redis(**redis_args) - return redis - def get_message_response(self, msg): queue = get_redis_queue_name_by_message(msg) if not queue: @@ -331,7 +316,7 @@ class Backend(Thread, EventGenerator, ExtensionWithManifest): return None try: - redis = self._get_redis() + redis = get_redis() response = redis.blpop(queue, timeout=60) if response and len(response) > 1: response = Message.build(response[1])