FIX: get_plugin methods should never swallow errors in case of failed initialization

platypush/context/__init__.py

@@ -4,6 +4,7 @@ import logging
 
 from threading import RLock
 
+from ..bus import Bus
 from ..config import Config
 from ..utils import get_enabled_plugins
 
@@ -129,8 +130,9 @@ def get_plugin(plugin_name, reload=False):
     return plugins[plugin_name]
 
 
-def get_bus():
+def get_bus() -> Bus:
     global main_bus
+    assert main_bus, 'The bus is not registered'
     return main_bus
 
 

platypush/plugins/inspect/__init__.py

@@ -191,7 +191,8 @@ class InspectPlugin(Plugin):
             try:
                 module = importlib.import_module(modname)
             except Exception as e:
-                self.logger.debug(f'Could not import module {modname}: {str(e)}')
+                self.logger.warning(f'Could not import module {modname}')
+                self.logger.exception(e)
                 continue
 
             for _, obj in inspect.getmembers(module):

platypush/utils/__init__.py

@@ -248,11 +248,12 @@ def set_thread_name(name):
 
 
 def find_bins_in_path(bin_name):
-    return [os.path.join(p, bin_name)
+    return [
+        os.path.join(p, bin_name)
         for p in os.environ.get('PATH', '').split(':')
-            if os.path.isfile(os.path.join(p, bin_name))
+        if os.path.isfile(os.path.join(p, bin_name)) and (
-            and (os.name == 'nt' or
+            os.name == 'nt' or os.access(os.path.join(p, bin_name), os.X_OK)
-                 os.access(os.path.join(p, bin_name), os.X_OK))]
+        )]
 
 
 def find_files_by_ext(directory, *exts):
@@ -444,7 +445,8 @@ def get_enabled_plugins() -> dict:
             if plugin:
                 plugins[name] = plugin
         except Exception as e:
-            logger.debug(f'Could not get plugin {name}: {e}')
+            logger.warning(f'Could not initialize plugin {name}')
+            logger.exception(e)
 
     return plugins