Psion-fanatic/platypush
1
0
Fork 0
forked from platypush/platypush
Code Pull requests Activity

_variable should be an external global function rather than a class property.

Browse source 
The combination of `@property` + `@classmethod` isn't supported on
Python < 3.9.
This commit is contained in:
Fabio Manganiello 2023-08-18 16:16:47 +02:00
parent d0c89f88a8
commit a9cdff900e
Signed by untrusted user: blacklight
GPG key ID: D90FBA7F76362774
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
platypush/plugins/rss/__init__.py
View file

@ -18,6 +18,12 @@ from platypush.plugins.variable import VariablePlugin
from platypush.schemas.rss import RssFeedEntrySchema from platypush.schemas.rss import RssFeedEntrySchema
def _variable() -> VariablePlugin:
var = get_plugin(VariablePlugin)
assert var, 'Could not load the variable plugin'
return var
class RssPlugin(RunnablePlugin): class RssPlugin(RunnablePlugin):
""" """
A plugin for parsing and subscribing to RSS feeds. A plugin for parsing and subscribing to RSS feeds.
@ -63,13 +69,6 @@ class RssPlugin(RunnablePlugin):
self.subscriptions = list(self._parse_subscriptions(subscriptions or [])) self.subscriptions = list(self._parse_subscriptions(subscriptions or []))
self._latest_timestamps = {} self._latest_timestamps = {}
@classmethod
@property
def _variable(cls) -> VariablePlugin:
var = get_plugin(VariablePlugin)
assert var, 'Could not load the variable plugin'
return var
@staticmethod @staticmethod
def _get_feed_latest_timestamp_varname(url: str) -> str: def _get_feed_latest_timestamp_varname(url: str) -> str:
return f'LATEST_FEED_TIMESTAMP[{url}]' return f'LATEST_FEED_TIMESTAMP[{url}]'
@ -77,7 +76,7 @@ class RssPlugin(RunnablePlugin):
@classmethod @classmethod
def _get_feed_latest_timestamp(cls, url: str) -> Optional[datetime.datetime]: def _get_feed_latest_timestamp(cls, url: str) -> Optional[datetime.datetime]:
varname = cls._get_feed_latest_timestamp_varname(url) varname = cls._get_feed_latest_timestamp_varname(url)
var: dict = cls._variable.get(varname).output or {} # type: ignore var: dict = _variable().get(varname).output or {} # type: ignore
t = var.get(varname) t = var.get(varname)
if t: if t:
@ -89,7 +88,7 @@ class RssPlugin(RunnablePlugin):
return {url: self._get_feed_latest_timestamp(url) for url in self.subscriptions} return {url: self._get_feed_latest_timestamp(url) for url in self.subscriptions}
def _update_latest_timestamps(self) -> None: def _update_latest_timestamps(self) -> None:
self._variable.set( _variable().set(
**{ **{
self._get_feed_latest_timestamp_varname(url): latest_timestamp self._get_feed_latest_timestamp_varname(url): latest_timestamp
for url, latest_timestamp in self._latest_timestamps.items() for url, latest_timestamp in self._latest_timestamps.items()