Add distinct keybindings for each compose view

commands/compose/send.go

@@ -17,7 +17,7 @@ import (
 )
 
 func init() {
-	register("send-message", SendMessage)
+	register("send", SendMessage)
 }
 
 func SendMessage(aerc *widgets.Aerc, args []string) error {

config/bindings.go

@@ -283,7 +283,7 @@ func init() {
 	keyNames["ACK"] = KeyStroke{tcell.KeyACK, 0}
 	keyNames["BEL"] = KeyStroke{tcell.KeyBEL, 0}
 	keyNames["BS"] = KeyStroke{tcell.KeyBS, 0}
-	keyNames["TAB"] = KeyStroke{tcell.KeyTAB, 0}
+	keyNames["tab"] = KeyStroke{tcell.KeyTAB, 0}
 	keyNames["LF"] = KeyStroke{tcell.KeyLF, 0}
 	keyNames["VT"] = KeyStroke{tcell.KeyVT, 0}
 	keyNames["FF"] = KeyStroke{tcell.KeyFF, 0}

config/binds.conf

@@ -40,6 +40,14 @@ a = :reply -a<Enter>
 f = :forward<Enter>
 
 [compose]
+# Keybindings used when the embedded terminal is not selected in the compose
+# view
+<C-k> = :prev-field<Enter>
+<C-j> = :next-field<Enter>
+<tab> = :next-field<Enter>
+
+[compose::editor]
+# Keybindings used when the embedded terminal is selected in the compose view
 $noinherit = true
 $ex = <semicolon>
 <C-k> = :prev-field<Enter>
@@ -47,6 +55,11 @@ $ex = <semicolon>
 <C-p> = :prev-tab<Enter>
 <C-n> = :next-tab<Enter>
 
+[compose::review]
+# Keybindings used when reviewing a message to be sent
+y = :send<Enter>
+n = :abort<Enter>
+
 [terminal]
 $noinherit = true
 $ex = <semicolon>

config/config.go

@@ -41,6 +41,8 @@ type AccountConfig struct {
 type BindingConfig struct {
 	Global        *KeyBindings
 	Compose       *KeyBindings
+	ComposeEditor *KeyBindings
+	ComposeReview *KeyBindings
 	MessageList   *KeyBindings
 	MessageView   *KeyBindings
 	Terminal      *KeyBindings
@@ -141,6 +143,8 @@ func LoadConfig(root *string) (*AercConfig, error) {
 		Bindings: BindingConfig{
 			Global:        NewKeyBindings(),
 			Compose:       NewKeyBindings(),
+			ComposeEditor: NewKeyBindings(),
+			ComposeReview: NewKeyBindings(),
 			MessageList:   NewKeyBindings(),
 			MessageView:   NewKeyBindings(),
 			Terminal:      NewKeyBindings(),
@@ -223,6 +227,9 @@ func LoadConfig(root *string) (*AercConfig, error) {
 		"messages": &config.Bindings.MessageList,
 		"terminal": &config.Bindings.Terminal,
 		"view":     &config.Bindings.MessageView,
+
+		"compose::editor": &config.Bindings.ComposeEditor,
+		"compose::review": &config.Bindings.ComposeReview,
 	}
 	for _, name := range binds.SectionStrings() {
 		sec, err := binds.GetSection(name)

widgets/aerc.go

@@ -88,11 +88,18 @@ func (aerc *Aerc) Draw(ctx *libui.Context) {
 }
 
 func (aerc *Aerc) getBindings() *config.KeyBindings {
-	switch aerc.SelectedTab().(type) {
+	switch view := aerc.SelectedTab().(type) {
 	case *AccountView:
 		return aerc.conf.Bindings.MessageList
 	case *Composer:
+		switch view.Bindings() {
+		case "compose::editor":
+			return aerc.conf.Bindings.ComposeEditor
+		case "compose::review":
+			return aerc.conf.Bindings.ComposeReview
+		default:
 			return aerc.conf.Bindings.Compose
+		}
 	case *MessageViewer:
 		return aerc.conf.Bindings.MessageView
 	case *Terminal:

widgets/compose.go

@@ -120,6 +120,16 @@ func (c *Composer) Close() {
 	}
 }
 
+func (c *Composer) Bindings() string {
+	if c.editor == nil {
+		return "compose::review"
+	} else if c.editor == c.focusable[c.focused] {
+		return "compose::editor"
+	} else {
+		return "compose"
+	}
+}
+
 func (c *Composer) Event(event tcell.Event) bool {
 	return c.focusable[c.focused].Event(event)
 }