Kevin Kuehler
a54f4adb8f
lib/ui/tab: Add Replace method
...
Also expose a light wrapper method in aerc.go for tab replacement
Signed-off-by: Kevin Kuehler <kkuehler@brave.com>
2019-06-11 09:34:45 -04:00
Kevin Kuehler
32f970e053
Move select functionality from msglist to msgstore
...
Remove msglist Next and Prev commands
Signed-off-by: Kevin Kuehler <kkuehler@brave.com>
2019-06-11 09:34:36 -04:00
Clayton Craft
dd178262bb
Select user's preferred mimetype in MessageViewer
...
This implements selecting the most preferred mimetype under the
'View->Alternatives' configuration setting when viewing a message.
Mimetypes in the alternatives array are weighted by their position,
where the lower the index in the array the higher the priority, so this
is taken into account during selection.
If no message part matches a mimetype in the alternatives array, then it
selects the first mimetype in the message.
2019-06-09 11:49:11 -04:00
Robert Günzler
acfe7d7625
Add archive command
...
Adds an archive command that moves the current message into the folder
specified in the account config entry.
Supports three layouts at this point:
- flat: puts all messages next to each other
- year: creates a folder per year
- month: same as above, plus folders per month
This also adds a "-p" argument to "cp" and "mv" that works like
"--parents" on mkdir(1). We use this to auto-create the directories
for the archive layout.
2019-06-09 11:33:50 -04:00
Yash Srivastav
5f651b32e5
msglist: use distinct style for unread emails
2019-06-08 10:59:51 -04:00
Drew DeVault
da62f63aad
Truncate long subject lines
2019-06-07 16:22:04 -04:00
Yash Srivastav
fca7321639
Message list: implement index-format option
2019-06-07 16:22:01 -04:00
Drew DeVault
0647ea6483
Move ANSI stripping from filters to Go
2019-06-07 11:14:50 -04:00
Drew DeVault
668f7f9e5d
Remove unnecessary branch
2019-06-07 10:19:29 -04:00
Drew DeVault
a974027efe
Execute the editor with the shell
...
Fixes #164
2019-06-07 10:15:35 -04:00
Drew DeVault
150a271b36
Add binding to toggle headers
2019-06-07 10:08:09 -04:00
Yash Srivastav
b83e7c9fa6
implements ability to view headers in message view
2019-06-07 09:20:24 -04:00
Lucas F. Souza
2279ac3ab3
Skip rendering dirlist if sidebar width is 0
2019-06-07 09:20:06 -04:00
Drew DeVault
92dc31bad0
Use SetAddressList for From header
2019-06-05 13:58:07 -04:00
JanUlrich
0771eaf24c
Introduce :new-account -t
...
Adding the [-t] temporary flag to the new-account command
- when using -t a newly created account will not be stored into the
accounts.conf
Issue #134
2019-06-05 09:32:43 -04:00
Drew DeVault
7d1770754f
Add date to message viewer
2019-06-02 10:23:53 -04:00
Kevin Kuehler
753adb9069
widget: Add ProvidesMessage interface
...
Consists of 3 functions
* Store: Access to MessageStore type
* SelectedAccount: Access to Account widget that the target widget
belongs to
* SelectedMessage: Current message (selected in msglist or the one we
are viewing)
Signed-off-by: Kevin Kuehler <keur@ocf.berkeley.edu>
2019-06-02 10:16:29 -04:00
Kevin Kuehler
5090a4c802
Only add message to store if store exists
...
Prevents the program from panicing when changing folders too quickly.
onMessage can race store creation for an AccountView.
Signed-off-by: Kevin Kuehler <keur@ocf.berkeley.edu>
2019-06-02 09:43:55 -04:00
Drew DeVault
6e745cb9f3
Enumerate Cc and Bcc lists in composer
2019-06-02 09:40:47 -04:00
Drew DeVault
7f434850b5
Simplify layout of message viewer grid
...
This sub-grid was an artifact of an older design
2019-06-02 09:33:41 -04:00
Drew DeVault
56b84d3da5
Use forked version of tcell
2019-06-01 11:28:29 -04:00
Kevin Kuehler
3445b80d7a
widgets/terminal: Don't segfault on resize
...
vterm.Write and vterm.SetSize race when the window resizes, which
causing the underlying library to segfault.
Signed-off-by: Kevin Kuehler <keur@ocf.berkeley.edu>
2019-06-01 11:09:14 -04:00
Galen Abell
28fc9fa53d
Add :save and :pipe commands to viewer
...
* :save takes a path and saves the current message part to that location
* :pipe is the same as pipe on the account page, but uses the current
message part rather than the whole email (ie :pipe gzip -d)
* Refactored account:pipe and extracted common pipe code to
commands.util.QuickTerm
* Added helper command aerc.PushError
2019-05-27 09:37:07 -04:00
Drew DeVault
62cd0b08aa
Update terminal color handling per vterm changes
2019-05-26 15:48:29 -04:00
Drew DeVault
855362d813
Update to the latest go-libvterm
2019-05-26 15:13:37 -04:00
Drew DeVault
887ff6550d
Implement :edit in compose screen
2019-05-26 11:58:14 -04:00
Drew DeVault
3cf6c82633
msgviewer: copy stderr into pager
...
This prevents a broken filter config from being a silent error
2019-05-26 11:18:51 -04:00
Drew DeVault
cef784bf52
Fix special characters in address.PersonalName
2019-05-25 11:56:56 -04:00
Drew DeVault
9b19e3ad05
Show account wizard if no accounts configured
2019-05-22 11:35:55 -04:00
Drew DeVault
58bc15b472
Implement opening tutorial after account wizard
2019-05-22 11:13:55 -04:00
Drew DeVault
937b33c850
Write new accounts to config and open tab
2019-05-22 10:40:08 -04:00
Drew DeVault
a7341aff21
Fix always showing last account tab
2019-05-22 10:39:52 -04:00
Drew DeVault
4d6e665204
Remove excess padding from incoming config page
2019-05-21 17:00:35 -04:00
Drew DeVault
6811143925
New account wizard, part one
2019-05-21 16:53:50 -04:00
Drew DeVault
2dc436555d
Load IMAP worker for imap+insecure
2019-05-20 19:28:04 -04:00
Drew DeVault
33f2d4f9ee
Show unsupported mimetype message in red
2019-05-20 17:05:37 -04:00
Drew DeVault
d224487b68
Show attachment names in multipart view
2019-05-20 17:03:37 -04:00
Drew DeVault
0897413a3e
Implement :next-part, :prev-part
2019-05-20 16:49:39 -04:00
Drew DeVault
511fea3944
Flesh out multipart switcher
2019-05-20 16:43:08 -04:00
Drew DeVault
3376f926ed
Refactor message part into dedicated widget
2019-05-20 15:03:47 -04:00
Drew DeVault
5de1bb8cc3
Verify TLS certificates
...
I was partway done implementing a UI for users to approve untrusted
certs with, but let's just make them configure their servers right
instead.
2019-05-20 14:03:00 -04:00
Drew DeVault
fa5d8d7a00
Advance cursor after :delete and :move
...
So that you can repeat the action on the next message if appropriate
2019-05-19 18:21:02 -04:00
Drew DeVault
f9251c2344
Reset message list cursor when switching stores
2019-05-19 18:18:48 -04:00
Drew DeVault
13032734cd
Advance message list cursor when messages arrive
2019-05-19 18:18:48 -04:00
Simon Ser
a15ea01cfb
Update internal state and draw from the same goroutine
...
This commit introduces a new Aerc.Tick function that should be called to
refresh the internal state. This in turn makes each AccountView process worker
events.
The UI goroutine repeatedly refreshes the internal state before drawing a new
frame. The reason for this is that many worker messages may need to be
processed for a single frame, and drawing the UI is far slower than refreshing
the internal state. This has been confirmed in my testing (calling Aerc.Tick
only once per frame results in a slower display).
Many synchronization code has been removed. We can now write widgets without
having to care so much about races. The remaining sync users are:
- widgets/spinner: the spinner value is updated from inside an internal
goroutine
- lib/ui/invalidatable: Invalidate may be called from any goroutine
- lib/ui/grid: same
- lib/ui/ui: an internal goroutine needs read access to UI.exit
- worker/types/worker: Worker.callbacks is used for both worker and UI
callbacks
The exact goroutine requirements for Drawable have been documented.
2019-05-19 11:51:16 -04:00
Simon Ser
1da3239345
widgets/terminal: fix damage race condition
...
Terminal.damage is accessed when drawing and when invalidating the widget. For
this reason we need to protect it with a mutex.
This seems to fix various damage issues I've been experiencing (where some
regions of the terminal weren't correctly repainted).
Race detector trace:
Read at 0x00c0000c6670 by main goroutine:
git.sr.ht/~sircmpwn/aerc/widgets.(*Terminal).Draw()
/home/simon/src/aerc/widgets/terminal.go:292 +0x191
git.sr.ht/~sircmpwn/aerc/lib/ui.(*Grid).Draw()
/home/simon/src/aerc/lib/ui/grid.go:117 +0x575
git.sr.ht/~sircmpwn/aerc/lib/ui.(*Grid).Draw()
/home/simon/src/aerc/lib/ui/grid.go:117 +0x575
git.sr.ht/~sircmpwn/aerc/widgets.(*MessageViewer).Draw()
/home/simon/src/aerc/widgets/msgviewer.go:231 +0x253
git.sr.ht/~sircmpwn/aerc/lib/ui.(*TabContent).Draw()
/home/simon/src/aerc/lib/ui/tab.go:124 +0x12e
git.sr.ht/~sircmpwn/aerc/lib/ui.(*Grid).Draw()
/home/simon/src/aerc/lib/ui/grid.go:117 +0x575
git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).Draw()
/home/simon/src/aerc/widgets/aerc.go:95 +0x5a
git.sr.ht/~sircmpwn/aerc/lib/ui.(*UI).Tick()
/home/simon/src/aerc/lib/ui/ui.go:93 +0x1dd
main.main()
/home/simon/src/aerc/aerc.go:105 +0x539
Previous write at 0x00c0000c6670 by goroutine 37:
git.sr.ht/~sircmpwn/aerc/widgets.(*Terminal).onDamage-fm()
/home/simon/src/aerc/widgets/terminal.go:429 +0x131
git.sr.ht/~sircmpwn/go-libvterm._go_handle_damage()
/home/simon/go/pkg/mod/git.sr.ht/~sircmpwn/go-libvterm@v0.0.0-20190421201021-3184f6f13687/vterm.go:481 +0xf9
git.sr.ht/~sircmpwn/go-libvterm._cgoexpwrap_5e22200b58b7__go_handle_damage()
_cgo_gotypes.go:731 +0x58
runtime.call32()
/usr/lib/go/src/runtime/asm_amd64.s:519 +0x3a
git.sr.ht/~sircmpwn/go-libvterm.(*VTerm).Write.func1()
/home/simon/go/pkg/mod/git.sr.ht/~sircmpwn/go-libvterm@v0.0.0-20190421201021-3184f6f13687/vterm.go:329 +0x9d
git.sr.ht/~sircmpwn/go-libvterm.(*VTerm).Write()
/home/simon/go/pkg/mod/git.sr.ht/~sircmpwn/go-libvterm@v0.0.0-20190421201021-3184f6f13687/vterm.go:329 +0x7f
git.sr.ht/~sircmpwn/aerc/widgets.NewTerminal.func1()
/home/simon/src/aerc/widgets/terminal.go:131 +0x18c
Goroutine 37 (running) created at:
git.sr.ht/~sircmpwn/aerc/widgets.NewTerminal()
/home/simon/src/aerc/widgets/terminal.go:121 +0x23f
git.sr.ht/~sircmpwn/aerc/widgets.NewMessageViewer()
/home/simon/src/aerc/widgets/msgviewer.go:147 +0xfbe
git.sr.ht/~sircmpwn/aerc/commands/account.ViewMessage()
/home/simon/src/aerc/commands/account/view-message.go:26 +0x4a4
git.sr.ht/~sircmpwn/aerc/commands.(*Commands).ExecuteCommand()
/home/simon/src/aerc/commands/commands.go:47 +0x1f0
main.main.func1()
/home/simon/src/aerc/aerc.go:76 +0x205
git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).BeginExCommand.func1()
/home/simon/src/aerc/widgets/aerc.go:262 +0x89
git.sr.ht/~sircmpwn/aerc/widgets.(*ExLine).Event()
/home/simon/src/aerc/widgets/exline.go:47 +0x222
git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).Event()
/home/simon/src/aerc/widgets/aerc.go:133 +0x83c
git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).simulate()
/home/simon/src/aerc/widgets/aerc.go:126 +0x12a
git.sr.ht/~sircmpwn/aerc/widgets.(*Aerc).Event()
/home/simon/src/aerc/widgets/aerc.go:148 +0x766
git.sr.ht/~sircmpwn/aerc/lib/ui.(*UI).Tick()
/home/simon/src/aerc/lib/ui/ui.go:86 +0x11b
main.main()
/home/simon/src/aerc/aerc.go:105 +0x539
2019-05-19 11:37:38 -04:00
Drew DeVault
98da4c9509
s/aerc2/aerc/g
2019-05-17 20:57:10 -04:00
Drew DeVault
fcdcd32de7
Remove unimplemented color configuration
...
Will probably end up doing this differently anyway
2019-05-17 11:52:38 -04:00
Drew DeVault
89ffd8653d
Implement ui.empty-message config option
...
Also removes some options that aren't going to be supported any time
soon.
2019-05-17 11:42:34 -04:00
Drew DeVault
23650ac0c7
Fix date header on outgoing emails
2019-05-17 11:05:21 -04:00