Commit graph

940 commits

Author SHA1 Message Date
Shaw Vrana
3c14c2cb34 Reapply 'Fix nil pointer deref on Envelope'
The commit bf16ccde48 appears to have been
unintentionally dropped by commit 905cb9dfd3
(Implement style configuration).
2021-01-03 09:08:27 +01:00
y0ast
889d89b42e Freshen up readme with binary packages 2020-12-27 10:02:47 +01:00
Bor Grošelj Simić
91f29206a3 s/RFC 8022/RFC 2822/ 2020-12-26 13:10:53 +01:00
y0ast
da265a56e4 Make makefile compatible with 3.81 (default MacOS)
Enables using the makefile with mac default make.
2020-12-24 10:56:16 +01:00
y0ast
3edbe0c67c add italics support
Fixes: https://todo.sr.ht/~sircmpwn/aerc2/416

Co-authored-by: JD <john1doe@ya.ru>
2020-12-24 10:26:18 +01:00
y0ast
03650474e2 update tcell to v2 and enable TrueColor support
Also update to the tcell v2 PaletteColor api, which should keep the chosen
theme of the user intact.

Note, that if $TRUECOLOR is defined and a truecolor given, aerc will now stop
clipping the value to one of the theme colors.
Generally this is desired behaviour though.
2020-12-18 07:23:22 +01:00
Reto Brunner
af0a2b9a46 Use extensions for querying the mime type of attachments
This gets rid of the issue that lots of things are detected as zip files, even
though they are a more specialized format (say office files)
2020-12-15 21:48:25 +01:00
Reto Brunner
83202dcb2e fix aerc-stylesets(7) typos 2020-12-13 10:30:56 +01:00
Kalyan Sriram
b56a688589 notmuch: trim excluded tags
Trims whitespace in list of excluded notmuch tags. This allows a comma
separated list with spaces to be correctly processed.
2020-12-02 09:08:19 +01:00
Reto Brunner
a9330f4c63 notmuch: remove gc close hooks
We frequently had issues with notmuch segfaulting and my guess is that this
was due to the garbage collection magic used in the module.

This changes to a fork that ripped the functionality out.
2020-12-02 09:06:34 +01:00
Reto Brunner
7bc556740a fix mailto parsing 2020-11-28 15:45:46 +01:00
Reto Brunner
67923707ff Refactor send command 2020-11-21 15:40:50 +01:00
Reto Brunner
7b12f2d1ea reply: add References header 2020-11-14 15:40:13 +01:00
Reto Brunner
daf214a1f8 imap: strip <> from message-ids 2020-11-14 15:40:13 +01:00
Reto Brunner
18b0ea571a lib/parse: use go-message msgid parsing if it succeeds 2020-11-14 15:40:13 +01:00
Reto Brunner
256af6322b allow the loading of existing headers 2020-11-14 15:40:13 +01:00
Reto Brunner
24f1c575ae format: remove parse methods, use the one from go-message 2020-11-14 15:40:13 +01:00
Reto Brunner
20ec2c8eeb compose: use a proper header instead of a string map
Prior to this commit, the composer was based on a map[string]string.
While this approach was very versatile, it lead to a constant encoding / decoding
of addresses and other headers.

This commit switches to a different model, where the composer is based on a header.
Commands which want to interact with it can simply set some defaults they would
like to have. Users can overwrite them however they like.

In order to get access to the functions generating / getting the msgid go-message
was upgraded.
2020-11-14 15:40:13 +01:00
Reto Brunner
3ad3a5ede0 models: add RFC822 headers to OriginalMail 2020-11-14 15:40:13 +01:00
Reto Brunner
e7d450c61d rename header to heditors 2020-11-14 15:40:13 +01:00
Reto Brunner
03fa9ad99b templates: Remove ParseTemplate as it's unused 2020-11-14 15:40:13 +01:00
Reto Brunner
fc9ccc3000 remove models.Address in favor of go-message Address
We made a new type out of go-message/mail.Address without any real reason.
This suddenly made it necessary to convert from one to the other without actually
having any benefit whatsoever.
This commit gets rid of the additional type
2020-11-14 15:40:13 +01:00
Reto Brunner
fb67d1f5a3 version bump: 0.5.2 2020-11-14 00:23:43 +01:00
Reto Brunner
a2fd88d2d4 makefile: add debug target 2020-11-13 23:54:00 +01:00
Andrew Jeffery
676fed9e22 Check account's from value is not empty
This leads to a nasty 'mail: no address' message for each email if left
empty so the user really should enter it.
2020-11-13 22:01:34 +01:00
Reto Brunner
a9ae91c2d8 templates: better error message 2020-11-11 13:58:05 +01:00
Reto Brunner
f6a0eb8e14 update the makefile version 2020-11-10 20:56:49 +01:00
Daniel Sockwell
a1467af03d Document pin-tab and unpin-tab commands
The `pin-tab` and `unpin-tab` global commands were added in 3156d48
but were not previously documented.  This documents them in aerc.1.
I added them with the other tab commands, which appeared to be grouped
as a logical unit.
2020-11-08 16:24:07 +01:00
Chris Vittal
f9bba3d17d Apply relevant msglist styles in order
Allow styles to be layered over a base style. The list of styles to
apply is layered over the base style in order, such that if the layer
does not differ from the base it is not used. The order that these
styles are applied in is, from first to last:

msglist_default
msglist_unread
msglist_read    (exclusive with unread, so technically the same level)
msglist_flagged
msglist_deleted
msglist_marked

So, msglist_marked style dominates.

This fixes an issue where the msglist_deleted style was not being applied.
2020-11-01 09:50:58 +01:00
y0ast
743683a0c1 update go-imap-sortthread
Fixes a problem with "Missing Sort Criteria" because go-imap-sortthread
wasn't sending the sort request in an RFC compliant way. This has been
fixed in the latest commit.
2020-10-18 10:43:48 +02:00
y0ast
0f584eb3e2 update go-imap
This fixes the problem that when the header contains "undisclosed-recipients:;",
which got parsed by go-imap as "<undisclosed-recipients@>, <@>".
If we do reply all, aerc adds these malformed emails to the To: field.
2020-10-15 09:12:25 +02:00
Reto Brunner
75cbf76732 refactor ParseMessageFormat to use a ctx object 2020-10-14 08:42:26 +02:00
Reto Brunner
b6bcf89784 imap: add sort support 2020-10-11 09:18:45 +02:00
Reto Brunner
d8a75a5159 notmuch: clarify comment char of query-maps 2020-10-08 20:42:05 +02:00
Reto Brunner
c48f228fa5 notmuch: rename method to SetFlag 2020-09-27 19:00:58 +02:00
JD
dadc9bf2b3 Makefile: remove aerc-stylesets upon uninstall 2020-09-27 15:35:04 +02:00
Reto Brunner
6654c970e6 notmuch: close tag object 2020-09-24 21:24:44 +02:00
y0ast
42ce6b41ff propagate error from sendmail 2020-09-22 08:12:38 +02:00
Reto Brunner
8bf100f7b4 reply: don't override the answered flag if we didn't send
Aerc just sent the true / false update regardless, meaning if someone already
replied to a mail, then drafted yet another mail to the same parent the flag
would vanish. This commit fixes this behaviour.
2020-09-21 20:43:22 +02:00
Josh Holland
4f40eecef8 doc: fix typo in aerc man page 2020-09-17 22:11:29 +02:00
Reto Brunner
84549e917d Update go-imap to latest commit
* return empty reader instead of nil when BODY is found but server returns nil
* utf7: fix package doc comment
* imap: lower some fields + content disposition keys
* remove "should not be called directly" comments and replaced them with links to the GitHub wiki pages
* backendutil: Improve Match function
* Write NIL for empty ENVELOPE fields
* readme: add NAMESPACE extension
* server: error when selecting should unselect
* Support NIL hierarchy delimiter
* backendutil: Implement message size and lines counting
* readme: update CI badge to only show status for commits
* Fix empty envelope address fields
* server: Return proper BAD response for cancelled SASL negotiation
* Replace empty string result in ErrStatusResp.Error
* Move ErrStatusResp to the root package
* Add MailboxInfoUpdate
* Fix BodyStructure fields documented as encoded
2020-09-15 07:07:16 +02:00
Seán C McCord
72d81ba603 doc: add oauth to aerc-smtp
Signed-off-by: Seán C McCord <ulexus@gmail.com>
2020-09-14 07:14:16 +02:00
Reto Brunner
9d80141408 Remove unused Simulator interface 2020-09-10 07:50:30 +02:00
Reto Brunner
504417b670 fix comment in ParseAddressList
Go pre 1.15 parsed an empty string as an error, 1.15 did not but this was
unintentional as per https://github.com/golang/go/issues/40803

Fix the comment accordingly
2020-09-10 07:35:56 +02:00
Reto Brunner
fe42beb3e4 dirlist: fix empty row if dir is added
There is a window where a new dir entry isn't yet in the dirlist.dir.
dirlist.ensureScroll however expected to always find a valid index.
Add a check so that we don't try to scroll to a -1 index.
2020-09-08 07:48:55 +02:00
y0ast
6ddd347b06 Make mimetype check consistent across cases 2020-09-07 07:27:15 +02:00
y0ast
f09e3966a7 correctly apply msglist_read color 2020-09-01 19:09:27 +02:00
Jeff Martin
0acb28645f handle message unknown charset error
This change handles message parse errors by printing the error when the
user tries to view the message. Specifically only handling unknown
charset errors in this patch, but there are many types of invalid
messages that can be handled in this way.

aerc currently leaves certain messages in the msglist in the pending
(spinner) state, and I'm unable to view or modify the message. aerc also
only prints parse errors with message when they are initially loaded.
This UX is a little better, because you can still see the header info
about the message, and if you try to view it, you will see the specific
error.
2020-08-31 22:00:28 +02:00
Reto Brunner
43c4f2f3ab update go-message 2020-08-31 21:48:07 +02:00
James Pond
dc0167b953 Fix color scheme for deleted emails
The color scheme for deleted emails should now match the old design,
making it easier to see when a message is deleted.

Signed-off-by: James Pond <james@cipher.host>
2020-08-31 09:06:13 +02:00