7 commits

Author	SHA1	Message	Date
Drew DeVault	f3158b36f1	Initial support for PGP decryption & signatures	2020-03-03 16:49:52 -05:00
Wiktor Kwapisiewicz	abd9e78f02	Fix crash when no message is selected ... Pressing `Enter` on a view that has not yet loaded messages (e.g. at startup) would return `nil` from `Selected()`. Accessing `msg.Uid` on a `nil` reference crashes aerc. This patch moves the `msg == nil` check before accessing `msg.Uid` thus avoiding the crash. To test this patch repeatedly press `Enter` on startup.	2019-12-04 09:45:07 -05:00
Kevin Kuehler	4966b912c6	commands/account: Disable :view for deleted msgs ... Allowing the user to view deleted messages creates all sorts of race conditions. The most devious race condition is pv.source can be set to a nil while another PartViewer is still running a goroutine in attemptCopy. Here is a trace when this happens. goroutine 76 [running]: io.copyBuffer(0x7f8ad02641d0, 0xc00040f590, 0x0, 0x0, 0xc0007cc000, 0x8000, 0x8000, 0x0, 0x0, 0x8b3d60) /usr/lib/go/src/io/io.go:402 +0x101 io.Copy(...) /usr/lib/go/src/io/io.go:364 git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy.func4(0xc00017efd0, 0xc0004da7c0) /home/keur/repos/aerc/widgets/msgviewer.go:576 +0x611 created by git.sr.ht/~sircmpwn/aerc/widgets.(*PartViewer).attemptCopy /home/keur/repos/aerc/widgets/msgviewer.go:544 +0x144 We could add a guard in store.FetchBodyPart to only call the callback when msg.Part.Reader != nil, but we still get a hanging pager. Therefore it seems more reasonable to disable this completely. Signed-off-by: Kevin Kuehler <keur@xcf.berkeley.edu>	2019-11-17 13:19:42 -05:00
Wagner Riffel	6838c23478	all: purge redundant underscores ... Signed-off-by: Wagner Riffel <wgrriffel@gmail.com>	2019-09-04 16:30:57 -10:00
Gregory Mullen	2a0961701c	Implement basic tab completion support ... Tab completion currently only works on commands. Contextual completion will be added in the future.	2019-06-29 14:24:19 -04:00
Kevin Kuehler	753adb9069	widget: Add ProvidesMessage interface ... Consists of 3 functions * Store: Access to MessageStore type * SelectedAccount: Access to Account widget that the target widget belongs to * SelectedMessage: Current message (selected in msglist or the one we are viewing) Signed-off-by: Kevin Kuehler <keur@ocf.berkeley.edu>	2019-06-02 10:16:29 -04:00
Drew DeVault	455c6f0b77	Rename :delete-message et al to :delete et al	2019-05-19 18:23:34 -04:00

Renamed from commands/account/view-message.go (Browse further)