9ef2a57b51
Worker.Process* functions were called in different goroutines than Worker.Post*. Protect the map with a mutex. Also make the map unexported to prevent external unprotected accesses. Worker.Process* functions used to delete items from the map. However they didn't delete the element they retrieved: callbacks[msg.InResponseTo()] was read while callbacks[msg] was deleted. I'm not sure I understand why. I tried to delete the element that was accessed - but this broke everything (UI froze at "Connecting..."). I don't believe any elements were actually removed from the map, so the new code just doesn't remove anything.
29 lines
586 B
Go
29 lines
586 B
Go
package worker
|
|
|
|
import (
|
|
"git.sr.ht/~sircmpwn/aerc2/worker/imap"
|
|
"git.sr.ht/~sircmpwn/aerc2/worker/types"
|
|
|
|
"fmt"
|
|
"log"
|
|
"net/url"
|
|
)
|
|
|
|
// Guesses the appropriate worker type based on the given source string
|
|
func NewWorker(source string, logger *log.Logger) (*types.Worker, error) {
|
|
u, err := url.Parse(source)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
worker := types.NewWorker(logger)
|
|
switch u.Scheme {
|
|
case "imap":
|
|
fallthrough
|
|
case "imaps":
|
|
worker.Backend = imap.NewIMAPWorker(worker)
|
|
default:
|
|
return nil, fmt.Errorf("Unknown backend %s", u.Scheme)
|
|
}
|
|
return worker, nil
|
|
}
|