c26d08103b
aerc.SelectedAccount() is used in lots of places. Most of them without checking the return value. In some cases, the currently selected tab is not related to any account (widget.Terminal for example). This can lead to unexpected crashes when accessing account specific configuration. When possible, return an error when no account is currently selected. If no error can be returned, fallback to non-account specific configuration. Signed-off-by: Robin Jarry <robin@jarry.cc> Reviewed-by: Koni Marti <koni.marti@gmail.com>
55 lines
1.2 KiB
Go
55 lines
1.2 KiB
Go
package msgview
|
|
|
|
import (
|
|
"errors"
|
|
|
|
"git.sr.ht/~rjarry/aerc/commands/account"
|
|
"git.sr.ht/~rjarry/aerc/lib"
|
|
"git.sr.ht/~rjarry/aerc/widgets"
|
|
)
|
|
|
|
type NextPrevMsg struct{}
|
|
|
|
func init() {
|
|
register(NextPrevMsg{})
|
|
}
|
|
|
|
func (NextPrevMsg) Aliases() []string {
|
|
return []string{"next", "next-message", "prev", "prev-message"}
|
|
}
|
|
|
|
func (NextPrevMsg) Complete(aerc *widgets.Aerc, args []string) []string {
|
|
return nil
|
|
}
|
|
|
|
func (NextPrevMsg) Execute(aerc *widgets.Aerc, args []string) error {
|
|
n, pct, err := account.ParseNextPrevMessage(args)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
mv, _ := aerc.SelectedTab().(*widgets.MessageViewer)
|
|
acct := mv.SelectedAccount()
|
|
if acct == nil {
|
|
return errors.New("No account selected")
|
|
}
|
|
store := mv.Store()
|
|
err = account.ExecuteNextPrevMessage(args, acct, pct, n)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
nextMsg := store.Selected()
|
|
if nextMsg == nil {
|
|
aerc.RemoveTab(mv)
|
|
return nil
|
|
}
|
|
lib.NewMessageStoreView(nextMsg, store, aerc.DecryptKeys,
|
|
func(view lib.MessageView, err error) {
|
|
if err != nil {
|
|
aerc.PushError(err.Error())
|
|
return
|
|
}
|
|
nextMv := widgets.NewMessageViewer(acct, aerc.Config(), view)
|
|
aerc.ReplaceTab(mv, nextMv, nextMsg.Envelope.Subject)
|
|
})
|
|
return nil
|
|
}
|