e804fac59f
The vulnerability database is evolving with time. It can cause the lint step to fail suddenly without any source code changes on our side. Moreover, sometimes, there is nothing we can do to fix the issue nor to silence that specific error. Found 1 known vulnerability. Vulnerability #1: GO-2022-1039 Programs which compile regular expressions from untrusted sources may be vulnerable to memory exhaustion or denial of service. The parsed regexp representation is linear in the size of the input, but in some cases the constant factor can be as high as 40,000, making relatively small regexps consume much larger amounts of memory. After fix, each regexp being parsed is limited to a 256 MB memory footprint. Regular expressions whose representation would use more space than that are rejected. Normal use of regular expressions is unaffected. Call stacks in your code: config/config.go:1000:46: git.sr.ht/~rjarry/aerc/config.AercConfig.LoadBinds calls regexp.Compile, which eventually calls regexp/syntax.Parse Found in: regexp/syntax@go1.18.6 Fixed in: regexp/syntax@go1.19.2 More info: https://pkg.go.dev/vuln/GO-2022-1039 Move govulncheck into its own make target to be executed manually. Signed-off-by: Robin Jarry <robin@jarry.cc> Acked-by: Tim Culverhouse <tim@timculverhouse.com>
170 lines
5.8 KiB
Makefile
170 lines
5.8 KiB
Makefile
.POSIX:
|
|
.SUFFIXES:
|
|
.SUFFIXES: .1 .5 .7 .1.scd .5.scd .7.scd
|
|
|
|
VERSION!=git describe --long --abbrev=12 --tags --dirty 2>/dev/null || echo 0.12.0
|
|
VPATH=doc
|
|
PREFIX?=/usr/local
|
|
BINDIR?=$(PREFIX)/bin
|
|
SHAREDIR?=$(PREFIX)/share/aerc
|
|
MANDIR?=$(PREFIX)/share/man
|
|
GO?=go
|
|
GOFLAGS?=
|
|
BUILD_OPTS?=-trimpath
|
|
flags!=echo -- $(GOFLAGS) | base64 | tr -d '\n'
|
|
# ignore environment variable
|
|
GO_LDFLAGS:=
|
|
GO_LDFLAGS+=-X main.Version=$(VERSION)
|
|
GO_LDFLAGS+=-X main.Flags=$(flags)
|
|
GO_LDFLAGS+=-X git.sr.ht/~rjarry/aerc/config.shareDir=$(SHAREDIR)
|
|
GO_LDFLAGS+=$(GO_EXTRA_LDFLAGS)
|
|
|
|
GOSRC!=find * -name '*.go'
|
|
GOSRC+=go.mod go.sum
|
|
|
|
DOCS := \
|
|
aerc.1 \
|
|
aerc-search.1 \
|
|
aerc-config.5 \
|
|
aerc-imap.5 \
|
|
aerc-maildir.5 \
|
|
aerc-sendmail.5 \
|
|
aerc-notmuch.5 \
|
|
aerc-smtp.5 \
|
|
aerc-tutorial.7 \
|
|
aerc-templates.7 \
|
|
aerc-stylesets.7
|
|
|
|
all: aerc $(DOCS)
|
|
|
|
build_cmd:=$(GO) build $(BUILD_OPTS) $(GOFLAGS) -ldflags "$(GO_LDFLAGS)" -o aerc
|
|
|
|
# the following command outputs nothing, we only want to execute it once
|
|
# and force .aerc.d to be regenerated when build_cmd has changed
|
|
_!=grep -sqFx '$(build_cmd)' .aerc.d || rm -f .aerc.d
|
|
|
|
.aerc.d:
|
|
@echo 'GOFLAGS have changed, recompiling'
|
|
@echo '$(build_cmd)' > $@
|
|
|
|
aerc: $(GOSRC) .aerc.d
|
|
$(build_cmd)
|
|
|
|
.PHONY: dev
|
|
dev:
|
|
$(MAKE) aerc BUILD_OPTS="-trimpath -race"
|
|
GORACE="log_path=race.log strip_path_prefix=git.sr.ht/~rjarry/aerc/" ./aerc
|
|
|
|
.PHONY: fmt
|
|
fmt:
|
|
$(GO) run mvdan.cc/gofumpt -w .
|
|
|
|
.PHONY: lint
|
|
lint:
|
|
@$(GO) run mvdan.cc/gofumpt -l . | grep ^ \
|
|
&& echo The above files need to be formatted, please run make fmt && exit 1 \
|
|
|| echo all files formatted.
|
|
$(GO) run github.com/golangci/golangci-lint/cmd/golangci-lint run
|
|
|
|
.PHONY: vulncheck
|
|
vulncheck:
|
|
$(GO) run golang.org/x/vuln/cmd/govulncheck@latest ./...
|
|
|
|
.PHONY: tests
|
|
tests:
|
|
$(GO) test $(GOFLAGS) -v ./...
|
|
|
|
.PHONY: debug
|
|
debug: aerc.debug
|
|
@echo 'Run `./aerc.debug` and use this command in another terminal to attach a debugger:'
|
|
@echo ' dlv attach $$(pidof aerc.debug)'
|
|
|
|
aerc.debug: $(GOSRC)
|
|
$(GO) build $(GOFLAGS) -gcflags=*=-N -gcflags=*=-l -ldflags="$(GO_LDFLAGS)" -o aerc.debug
|
|
|
|
.1.scd.1:
|
|
scdoc < $< > $@
|
|
|
|
.5.scd.5:
|
|
scdoc < $< > $@
|
|
|
|
.7.scd.7:
|
|
scdoc < $< > $@
|
|
|
|
doc: $(DOCS)
|
|
|
|
# Exists in GNUMake but not in NetBSD make and others.
|
|
RM?=rm -f
|
|
|
|
clean:
|
|
$(RM) $(DOCS) aerc
|
|
|
|
install: $(DOCS) aerc
|
|
mkdir -m755 -p $(DESTDIR)$(BINDIR) $(DESTDIR)$(MANDIR)/man1 $(DESTDIR)$(MANDIR)/man5 $(DESTDIR)$(MANDIR)/man7 \
|
|
$(DESTDIR)$(SHAREDIR) $(DESTDIR)$(SHAREDIR)/filters $(DESTDIR)$(SHAREDIR)/templates $(DESTDIR)$(SHAREDIR)/stylesets \
|
|
$(DESTDIR)$(PREFIX)/share/applications
|
|
install -m755 aerc $(DESTDIR)$(BINDIR)/aerc
|
|
install -m644 aerc.1 $(DESTDIR)$(MANDIR)/man1/aerc.1
|
|
install -m644 aerc-search.1 $(DESTDIR)$(MANDIR)/man1/aerc-search.1
|
|
install -m644 aerc-config.5 $(DESTDIR)$(MANDIR)/man5/aerc-config.5
|
|
install -m644 aerc-imap.5 $(DESTDIR)$(MANDIR)/man5/aerc-imap.5
|
|
install -m644 aerc-maildir.5 $(DESTDIR)$(MANDIR)/man5/aerc-maildir.5
|
|
install -m644 aerc-sendmail.5 $(DESTDIR)$(MANDIR)/man5/aerc-sendmail.5
|
|
install -m644 aerc-notmuch.5 $(DESTDIR)$(MANDIR)/man5/aerc-notmuch.5
|
|
install -m644 aerc-smtp.5 $(DESTDIR)$(MANDIR)/man5/aerc-smtp.5
|
|
install -m644 aerc-tutorial.7 $(DESTDIR)$(MANDIR)/man7/aerc-tutorial.7
|
|
install -m644 aerc-templates.7 $(DESTDIR)$(MANDIR)/man7/aerc-templates.7
|
|
install -m644 aerc-stylesets.7 $(DESTDIR)$(MANDIR)/man7/aerc-stylesets.7
|
|
install -m644 config/accounts.conf $(DESTDIR)$(SHAREDIR)/accounts.conf
|
|
install -m644 config/aerc.conf $(DESTDIR)$(SHAREDIR)/aerc.conf
|
|
install -m644 config/binds.conf $(DESTDIR)$(SHAREDIR)/binds.conf
|
|
install -m755 filters/calendar $(DESTDIR)$(SHAREDIR)/filters/calendar
|
|
install -m755 filters/colorize $(DESTDIR)$(SHAREDIR)/filters/colorize
|
|
install -m755 filters/hldiff $(DESTDIR)$(SHAREDIR)/filters/hldiff
|
|
install -m755 filters/html $(DESTDIR)$(SHAREDIR)/filters/html
|
|
install -m755 filters/html-unsafe $(DESTDIR)$(SHAREDIR)/filters/html-unsafe
|
|
install -m755 filters/plaintext $(DESTDIR)$(SHAREDIR)/filters/plaintext
|
|
install -m755 filters/show-ics-details.py $(DESTDIR)$(SHAREDIR)/filters/show-ics-details.py
|
|
install -m644 templates/new_message $(DESTDIR)$(SHAREDIR)/templates/new_message
|
|
install -m644 templates/quoted_reply $(DESTDIR)$(SHAREDIR)/templates/quoted_reply
|
|
install -m644 templates/forward_as_body $(DESTDIR)$(SHAREDIR)/templates/forward_as_body
|
|
install -m644 config/default_styleset $(DESTDIR)$(SHAREDIR)/stylesets/default
|
|
install -m644 contrib/aerc.desktop $(DESTDIR)$(PREFIX)/share/applications/aerc.desktop
|
|
|
|
.PHONY: checkinstall
|
|
checkinstall:
|
|
$(DESTDIR)$(BINDIR)/aerc -v
|
|
test -e $(DESTDIR)$(MANDIR)/man1/aerc.1
|
|
test -e $(DESTDIR)$(MANDIR)/man5/aerc-config.5
|
|
test -e $(DESTDIR)$(MANDIR)/man5/aerc-imap.5
|
|
test -e $(DESTDIR)$(MANDIR)/man5/aerc-notmuch.5
|
|
test -e $(DESTDIR)$(MANDIR)/man5/aerc-sendmail.5
|
|
test -e $(DESTDIR)$(MANDIR)/man5/aerc-smtp.5
|
|
test -e $(DESTDIR)$(MANDIR)/man7/aerc-tutorial.7
|
|
test -e $(DESTDIR)$(MANDIR)/man7/aerc-templates.7
|
|
|
|
RMDIR_IF_EMPTY:=sh -c '! [ -d $$0 ] || ls -1qA $$0 | grep -q . || rmdir $$0'
|
|
|
|
uninstall:
|
|
$(RM) $(DESTDIR)$(BINDIR)/aerc
|
|
$(RM) $(DESTDIR)$(MANDIR)/man1/aerc.1
|
|
$(RM) $(DESTDIR)$(MANDIR)/man1/aerc-search.1
|
|
$(RM) $(DESTDIR)$(MANDIR)/man5/aerc-config.5
|
|
$(RM) $(DESTDIR)$(MANDIR)/man5/aerc-imap.5
|
|
$(RM) $(DESTDIR)$(MANDIR)/man5/aerc-maildir.5
|
|
$(RM) $(DESTDIR)$(MANDIR)/man5/aerc-sendmail.5
|
|
$(RM) $(DESTDIR)$(MANDIR)/man5/aerc-notmuch.5
|
|
$(RM) $(DESTDIR)$(MANDIR)/man5/aerc-smtp.5
|
|
$(RM) $(DESTDIR)$(MANDIR)/man7/aerc-tutorial.7
|
|
$(RM) $(DESTDIR)$(MANDIR)/man7/aerc-templates.7
|
|
$(RM) $(DESTDIR)$(MANDIR)/man7/aerc-stylesets.7
|
|
$(RM) -r $(DESTDIR)$(SHAREDIR)
|
|
${RMDIR_IF_EMPTY} $(DESTDIR)$(BINDIR)
|
|
$(RMDIR_IF_EMPTY) $(DESTDIR)$(MANDIR)/man1
|
|
$(RMDIR_IF_EMPTY) $(DESTDIR)$(MANDIR)/man5
|
|
$(RMDIR_IF_EMPTY) $(DESTDIR)$(MANDIR)/man7
|
|
$(RMDIR_IF_EMPTY) $(DESTDIR)$(MANDIR)
|
|
$(RM) $(DESTDIR)$(PREFIX)/share/applications/aerc.desktop
|
|
$(RMDIR_IF_EMPTY) $(DESTDIR)$(PREFIX)/share/applications
|
|
|
|
.PHONY: all doc clean install uninstall debug
|