aerc/lib/ui/ui.go
Simon Ser de122b16ee lib/ui: fix UI.Exit race condition
UI.Exit can be accessed from goroutines drawing, goroutines executing
commands and goroutines waiting for events.

    Write at 0x00c0002b2040 by main goroutine:
      main.main.func1()
          /home/simon/src/aerc2/aerc.go:76 +0x33d
      git.sr.ht/~sircmpwn/aerc2/widgets.(*Aerc).BeginExCommand.func1()
          /home/simon/src/aerc2/widgets/aerc.go:245 +0x89
      git.sr.ht/~sircmpwn/aerc2/widgets.(*ExLine).Event()
          /home/simon/src/aerc2/widgets/exline.go:131 +0x442
      git.sr.ht/~sircmpwn/aerc2/widgets.(*Aerc).Event()
          /home/simon/src/aerc2/widgets/aerc.go:116 +0x83c
      git.sr.ht/~sircmpwn/aerc2/widgets.(*Aerc).simulate()
          /home/simon/src/aerc2/widgets/aerc.go:109 +0x12a
      git.sr.ht/~sircmpwn/aerc2/widgets.(*Aerc).Event()
          /home/simon/src/aerc2/widgets/aerc.go:142 +0x722
      git.sr.ht/~sircmpwn/aerc2/lib/ui.(*UI).Tick()
          /home/simon/src/aerc2/lib/ui/ui.go:75 +0x33f
      main.main()
          /home/simon/src/aerc2/aerc.go:94 +0x497

    Previous read at 0x00c0002b2040 by goroutine 19:
      git.sr.ht/~sircmpwn/aerc2/lib/ui.Initialize.func1()
          /home/simon/src/aerc2/lib/ui/ui.go:45 +0x97

    Goroutine 19 (running) created at:
      git.sr.ht/~sircmpwn/aerc2/lib/ui.Initialize()
          /home/simon/src/aerc2/lib/ui/ui.go:44 +0x372
      main.main()
          /home/simon/src/aerc2/aerc.go:87 +0x3a9
2019-05-05 01:07:44 -04:00

104 lines
1.8 KiB
Go

package ui
import (
"sync/atomic"
"github.com/gdamore/tcell"
"git.sr.ht/~sircmpwn/aerc2/config"
)
type UI struct {
Content DrawableInteractive
exit atomic.Value
ctx *Context
screen tcell.Screen
tcEvents chan tcell.Event
invalidations chan interface{}
}
func Initialize(conf *config.AercConfig,
content DrawableInteractive) (*UI, error) {
screen, err := tcell.NewScreen()
if err != nil {
return nil, err
}
if err = screen.Init(); err != nil {
return nil, err
}
screen.Clear()
screen.HideCursor()
width, height := screen.Size()
state := UI{
Content: content,
ctx: NewContext(width, height, screen),
screen: screen,
tcEvents: make(chan tcell.Event, 10),
invalidations: make(chan interface{}),
}
state.exit.Store(false)
go (func() {
for !state.ShouldExit() {
state.tcEvents <- screen.PollEvent()
}
})()
go (func() {
state.invalidations <- nil
})()
content.OnInvalidate(func(_ Drawable) {
go (func() {
state.invalidations <- nil
})()
})
content.Focus(true)
return &state, nil
}
func (state *UI) ShouldExit() bool {
return state.exit.Load().(bool)
}
func (state *UI) Exit() {
state.exit.Store(true)
}
func (state *UI) Close() {
state.screen.Fini()
}
func (state *UI) Tick() bool {
select {
case event := <-state.tcEvents:
switch event := event.(type) {
case *tcell.EventResize:
state.screen.Clear()
width, height := event.Size()
state.ctx = NewContext(width, height, state.screen)
state.Content.Invalidate()
}
state.Content.Event(event)
case <-state.invalidations:
for {
// Flush any other pending invalidations
select {
case <-state.invalidations:
break
default:
goto done
}
}
done:
state.Content.Draw(state.ctx)
state.screen.Show()
default:
return false
}
return true
}