8f9bb2b289
Signed and/or encrypted PGP messages did not behave properly for pipe, open, and save commands. Specifically, the proper Message Part would not be passed to the command in the MessageViewer. This is due to the encapsulation of the body structure. This patch fixes the behavior for piping|opening|saving of message parts. Fixes: https://todo.sr.ht/~rjarry/aerc/47 Reported-by: ~ph14nix Signed-off-by: Tim Culverhouse <tim@timculverhouse.com> Tested-by: Moritz Poldrack <moritz@poldrack.dev> Acked-by: Robin Jarry <robin@jarry.cc>
237 lines
5.2 KiB
Go
237 lines
5.2 KiB
Go
package msgview
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"time"
|
|
|
|
"git.sr.ht/~sircmpwn/getopt"
|
|
"github.com/mitchellh/go-homedir"
|
|
|
|
"git.sr.ht/~rjarry/aerc/commands"
|
|
"git.sr.ht/~rjarry/aerc/logging"
|
|
"git.sr.ht/~rjarry/aerc/models"
|
|
"git.sr.ht/~rjarry/aerc/widgets"
|
|
)
|
|
|
|
type Save struct{}
|
|
|
|
func init() {
|
|
register(Save{})
|
|
}
|
|
|
|
func (Save) Aliases() []string {
|
|
return []string{"save"}
|
|
}
|
|
|
|
func (Save) Complete(aerc *widgets.Aerc, args []string) []string {
|
|
_, optind, _ := getopt.Getopts(args, "fpa")
|
|
if optind < len(args) {
|
|
args = args[optind:]
|
|
}
|
|
path := strings.Join(args, " ")
|
|
defaultPath := aerc.Config().General.DefaultSavePath
|
|
if defaultPath != "" && !isAbsPath(path) {
|
|
path = filepath.Join(defaultPath, path)
|
|
}
|
|
path, _ = homedir.Expand(path)
|
|
return commands.CompletePath(path)
|
|
}
|
|
|
|
type saveParams struct {
|
|
force bool
|
|
createDirs bool
|
|
trailingSlash bool
|
|
attachments bool
|
|
}
|
|
|
|
func (Save) Execute(aerc *widgets.Aerc, args []string) error {
|
|
opts, optind, err := getopt.Getopts(args, "fpa")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
var params saveParams
|
|
|
|
for _, opt := range opts {
|
|
switch opt.Option {
|
|
case 'f':
|
|
params.force = true
|
|
case 'p':
|
|
params.createDirs = true
|
|
case 'a':
|
|
params.attachments = true
|
|
}
|
|
}
|
|
|
|
defaultPath := aerc.Config().General.DefaultSavePath
|
|
// we either need a path or a defaultPath
|
|
if defaultPath == "" && len(args) == optind {
|
|
return errors.New("Usage: :save [-fpa] <path>")
|
|
}
|
|
|
|
// as a convenience we join with spaces, so that the user doesn't need to
|
|
// quote filenames containing spaces
|
|
path := strings.Join(args[optind:], " ")
|
|
|
|
// needs to be determined prior to calling filepath.Clean / filepath.Join
|
|
// it gets stripped by Clean.
|
|
// we auto generate a name if a directory was given
|
|
if len(path) > 0 {
|
|
params.trailingSlash = path[len(path)-1] == '/'
|
|
} else if len(defaultPath) > 0 && len(path) == 0 {
|
|
// empty path, so we might have a default that ends in a trailingSlash
|
|
params.trailingSlash = defaultPath[len(defaultPath)-1] == '/'
|
|
}
|
|
|
|
// Absolute paths are taken as is so that the user can override the default
|
|
// if they want to
|
|
if !isAbsPath(path) {
|
|
path = filepath.Join(defaultPath, path)
|
|
}
|
|
|
|
path, err = homedir.Expand(path)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
mv, ok := aerc.SelectedTab().(*widgets.MessageViewer)
|
|
if !ok {
|
|
return fmt.Errorf("SelectedTab is not a MessageViewer")
|
|
}
|
|
|
|
if params.attachments {
|
|
parts := mv.AttachmentParts()
|
|
if len(parts) == 0 {
|
|
return fmt.Errorf("This message has no attachments")
|
|
}
|
|
params.trailingSlash = true
|
|
for _, pi := range parts {
|
|
if err := savePart(pi, path, mv, aerc, ¶ms); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
pi := mv.SelectedMessagePart()
|
|
return savePart(pi, path, mv, aerc, ¶ms)
|
|
}
|
|
|
|
func savePart(
|
|
pi *widgets.PartInfo,
|
|
path string,
|
|
mv *widgets.MessageViewer,
|
|
aerc *widgets.Aerc,
|
|
params *saveParams,
|
|
) error {
|
|
|
|
if params.trailingSlash || isDirExists(path) {
|
|
filename := generateFilename(pi.Part)
|
|
path = filepath.Join(path, filename)
|
|
}
|
|
|
|
dir := filepath.Dir(path)
|
|
if params.createDirs && dir != "" {
|
|
err := os.MkdirAll(dir, 0755)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if pathExists(path) && !params.force {
|
|
return fmt.Errorf("%q already exists and -f not given", path)
|
|
}
|
|
|
|
ch := make(chan error, 1)
|
|
mv.MessageView().FetchBodyPart(pi.Index, func(reader io.Reader) {
|
|
f, err := os.Create(path)
|
|
if err != nil {
|
|
ch <- err
|
|
return
|
|
}
|
|
defer f.Close()
|
|
_, err = io.Copy(f, reader)
|
|
if err != nil {
|
|
ch <- err
|
|
return
|
|
}
|
|
ch <- nil
|
|
})
|
|
|
|
// we need to wait for the callback prior to displaying a result
|
|
go func() {
|
|
defer logging.PanicHandler()
|
|
|
|
err := <-ch
|
|
if err != nil {
|
|
aerc.PushError(fmt.Sprintf("Save failed: %v", err))
|
|
return
|
|
}
|
|
aerc.PushStatus("Saved to "+path, 10*time.Second)
|
|
}()
|
|
return nil
|
|
}
|
|
|
|
//isDir returns true if path is a directory and exists
|
|
func isDirExists(path string) bool {
|
|
pathinfo, err := os.Stat(path)
|
|
if err != nil {
|
|
return false // we don't really care
|
|
}
|
|
if pathinfo.IsDir() {
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
|
|
//pathExists returns true if path exists
|
|
func pathExists(path string) bool {
|
|
_, err := os.Stat(path)
|
|
|
|
return err == nil
|
|
}
|
|
|
|
//isAbsPath returns true if path given is anchored to / or . or ~
|
|
func isAbsPath(path string) bool {
|
|
if len(path) == 0 {
|
|
return false
|
|
}
|
|
switch path[0] {
|
|
case '/':
|
|
return true
|
|
case '.':
|
|
return true
|
|
case '~':
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
|
|
// generateFilename tries to get the filename from the given part.
|
|
// if that fails it will fallback to a generated one based on the date
|
|
func generateFilename(part *models.BodyStructure) string {
|
|
var filename string
|
|
if fn, ok := part.DispositionParams["filename"]; ok {
|
|
filename = fn
|
|
} else if fn, ok := part.Params["name"]; ok {
|
|
filename = fn
|
|
}
|
|
// Some MUAs send attachments with names like /some/stupid/idea/happy.jpeg
|
|
// Assuming non hostile intent it does make sense to use just the last
|
|
// portion of the pathname as the filename for saving it.
|
|
filename = filename[strings.LastIndex(filename, "/")+1:]
|
|
switch filename {
|
|
case "", ".", "..":
|
|
timestamp := time.Now().Format("2006-01-02-150405")
|
|
filename = fmt.Sprintf("aerc_%v", timestamp)
|
|
default:
|
|
// already have a valid name
|
|
}
|
|
return filename
|
|
}
|