blacklight/aerc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
aerc/worker
History
Robin Jarry 6ddfc23e61 imap: fix segfault when disconnecting 
Do not set client = nil, it breaks almost all message handlers:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x8c7e51]
goroutine 25 [running]:
  git.sr.ht/~rjarry/aerc/worker/imap.(*IMAPWorker).handleListDirectories
    worker/imap/list.go:32
  git.sr.ht/~rjarry/aerc/worker/imap.(*IMAPWorker).handleMessage
    worker/imap/worker.go:174
  git.sr.ht/~rjarry/aerc/worker/imap.(*IMAPWorker).Run
    worker/imap/worker.go:264
  created by git.sr.ht/~rjarry/aerc/widgets.NewAccountView
    widgets/account.go:85 +0x518

Simply leave the disconnected client object, it already returns explicit
error messages.

Fixes: e41ed82cf3 ("imap: add manual {dis,}connect support")
Signed-off-by: Robin Jarry <robin@jarry.cc>
2021-11-22 21:32:56 +01:00
..
handlers go.mod: change base git url 2021-11-05 10:21:45 +01:00
imap imap: fix segfault when disconnecting 2021-11-22 21:32:56 +01:00
lib go.mod: change base git url 2021-11-05 10:21:45 +01:00
maildir go.mod: change base git url 2021-11-05 10:21:45 +01:00
notmuch notmuch: allow sort by file order 2021-11-13 15:25:04 +01:00
types messages: allow displaying email threads 2021-11-13 15:05:59 +01:00
handler_notmuch.go go.mod: change base git url 2021-11-05 10:21:45 +01:00
worker.go go.mod: change base git url 2021-11-05 10:21:45 +01:00
worker_enabled.go go.mod: change base git url 2021-11-05 10:21:45 +01:00