049c72393a
The Invalidatable struct is designed so that a widget can have a callback function ran when it is Invalidated. This is used to cascade up the widget tree, marking things as Invalid along the way so that only Invalid widgets are drawn. However, this is only implemented at the grid cell level for checks if the cell is invalidated -- and the grid cells are never set back to a "valid" state. The effect of this is that no matter what is invalidated, the entire UI gets drawn again. The calling through the Invalidate callbacks creates *several* race conditions, as Invalidate is called from several different goroutines, and many widgets call invalidate on their parent or children. Tcell has optimizations to only rerender screen cells that have changed their rune and style. The only performance penalty by redrawing the entire screen for aerc is the operations *within the aerc draw methods*. Most of these are not expensive and have relatively no impact on performance. Skip all of the OnInvalidates, and directly invalidate the UI when DoInvalidate is called by a widget. This reduces data races, and simplifies the widget redraw logic signficantly. Signed-off-by: Tim Culverhouse <tim@timculverhouse.com> Acked-by: Robin Jarry <robin@jarry.cc>
17 lines
271 B
Go
17 lines
271 B
Go
package ui
|
|
|
|
import (
|
|
"sync/atomic"
|
|
)
|
|
|
|
type Invalidatable struct {
|
|
onInvalidate atomic.Value
|
|
}
|
|
|
|
func (i *Invalidatable) OnInvalidate(f func(d Drawable)) {
|
|
i.onInvalidate.Store(f)
|
|
}
|
|
|
|
func (i *Invalidatable) DoInvalidate(d Drawable) {
|
|
atomic.StoreInt32(&dirty, DIRTY)
|
|
}
|