platypush/platypush
platypush
/
platypush
2
2
Fork 4
Code Issues 43 Pull Requests Packages Projects 4 Releases Wiki Activity

Always handle at least one retry on mpd plugin _exec method, the TCP connection to a mopidy server can really be shaky

This commit is contained in:
Fabio Manganiello 2019-02-13 17:35:18 +01:00
parent 7c817ba0c6
commit 32cdab5530
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
platypush/plugins/music/mpd/__init__.py
View File

@ -43,7 +43,7 @@ class MusicMpdPlugin(MusicPlugin):
self.client.connect(self.host, self.port)
return self.client
def _exec(self, method, *args, **kwargs):
def _exec(self, method, n_tries=2, *args, **kwargs):
return_status = kwargs.pop('return_status') \
if 'return_status' in kwargs else True
@ -60,7 +60,12 @@ class MusicMpdPlugin(MusicPlugin):
self.logger.warning('Exception while executing MPD method {}: {}'.
format(method, str(e)))
self.client = None
return (None, str(e))
if n_tries > 0:
return self._exec(method, n_tries=n_tries-1,
return_status=return_status, *args, **kwargs)
else:
return (None, str(e))
@action
def play(self, resource=None):