a6cafaa1fc
PostResponse::Paragraph's that are of type IFRAME have extra data in the iframe attribute to specify what's in the iframe. Not all data is the same, however. I've identified three types and am using the new EmbeddedConverter class to convert them: * EmbeddedContent, the full iframe experience * GithubGist, because medium or github treat embeds differently for whatever reason * EmbeddedLink, the old style, just a link to the content. Effectively a fallback The size of the original iframe is also specified as an attribute. This code resizes it. The resizing is determined by figuring out the width/height ratio and setting the width to 800. EmbeddedContent can be displayed if we have an embed.ly url, which most iframe response data has. GitHub gists are a notable exception. Gists instead can be embedded simply by taking the gist URL and attaching .js to the end. That becomes the iframe's src attribute. The PostResponse::Paragraph's iframe attribute is nillable. Previous code used lots of if-statements with variable bindings to work with the possible nil values: ```crystal if foo = obj.nillable_value # obj.nillable_value was not nil and foo contains the value else # obj.nillable_value was nil so do something else end ``` See https://crystal-lang.org/reference/syntax_and_semantics/if_var.html for more info In the EmbeddedConverter the monads library has been introduced to get rid of at least one level of nillability. This wraps values in Maybe which allows for a cleaner interface: ```crystal Monads::Try(Value).new(->{ obj.nillable_value }) .to_maybe .fmap(->(value: Value) { # do something with value }) .value_or(# value was nil, do something else) ``` This worked to get the iframe attribute from a Paragraph: ```crystal Monads::Try(PostResponse::IFrame).new(->{ paragraph.iframe }) .to_maybe .fmap(->(iframe : PostResponse::IFrame) { # iframe is not nil! }) .fmap(#and so on) .value_or(Empty.new) ``` iframe only has one attribute: mediaResource which contains the iframe data. That was used to determine one of the three types above. Finally, Tufte.css has options for iframes. They mostly look good except for tweets which are too small and weirdly in the center of the page which actually looks off-center. That's for another day though.
99 lines
2.6 KiB
Crystal
99 lines
2.6 KiB
Crystal
require "../spec_helper"
|
|
|
|
include Nodes
|
|
|
|
describe EmbeddedConverter do
|
|
context "when the mediaResource has an iframeSrc value" do
|
|
it "returns an EmbeddedContent node" do
|
|
paragraph = PostResponse::Paragraph.from_json <<-JSON
|
|
{
|
|
"text": "",
|
|
"type": "IFRAME",
|
|
"href": null,
|
|
"layout": "INSET_CENTER",
|
|
"markups": [],
|
|
"iframe": {
|
|
"mediaResource": {
|
|
"id": "abc123",
|
|
"href": "https://twitter.com/user/status/1",
|
|
"iframeSrc": "https://cdn.embedly.com/widgets/...",
|
|
"iframeWidth": 500,
|
|
"iframeHeight": 281
|
|
}
|
|
},
|
|
"metadata": null
|
|
}
|
|
JSON
|
|
|
|
result = EmbeddedConverter.convert(paragraph)
|
|
|
|
result.should eq(
|
|
EmbeddedContent.new(
|
|
src: "https://cdn.embedly.com/widgets/...",
|
|
originalWidth: 500,
|
|
originalHeight: 281,
|
|
)
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when the mediaResource has a blank iframeSrc value" do
|
|
context "and the href is unknown" do
|
|
it "returns an EmbeddedLink node" do
|
|
paragraph = PostResponse::Paragraph.from_json <<-JSON
|
|
{
|
|
"text": "",
|
|
"type": "IFRAME",
|
|
"href": null,
|
|
"layout": "INSET_CENTER",
|
|
"markups": [],
|
|
"iframe": {
|
|
"mediaResource": {
|
|
"id": "abc123",
|
|
"href": "https://example.com",
|
|
"iframeSrc": "",
|
|
"iframeWidth": 0,
|
|
"iframeHeight": 0
|
|
}
|
|
},
|
|
"metadata": null
|
|
}
|
|
JSON
|
|
|
|
result = EmbeddedConverter.convert(paragraph)
|
|
|
|
result.should eq(EmbeddedLink.new(href: "https://example.com"))
|
|
end
|
|
end
|
|
|
|
context "and the href is gist.github.com" do
|
|
it "returns an GithubGist node" do
|
|
paragraph = PostResponse::Paragraph.from_json <<-JSON
|
|
{
|
|
"text": "",
|
|
"type": "IFRAME",
|
|
"href": null,
|
|
"layout": "INSET_CENTER",
|
|
"markups": [],
|
|
"iframe": {
|
|
"mediaResource": {
|
|
"id": "abc123",
|
|
"href": "https://gist.github.com/user/someid",
|
|
"iframeSrc": "",
|
|
"iframeWidth": 0,
|
|
"iframeHeight": 0
|
|
}
|
|
},
|
|
"metadata": null
|
|
}
|
|
JSON
|
|
|
|
result = EmbeddedConverter.convert(paragraph)
|
|
|
|
result.should eq(
|
|
GithubGist.new(href: "https://gist.github.com/user/someid")
|
|
)
|
|
end
|
|
end
|
|
end
|
|
end
|