platypush/platypush

Fork 4

[#272] Support for external stop/restart control on the application #273

Merged

blacklight merged 18 commits from 272/external-proc-controller into master

2023-08-15 21:34:44 +02:00

blacklight commented

2023-08-15 11:42:07 +02:00

Owner

This adds the application.stop and application.restart actions.

It also greatly improves the stability of the stop mechanism, preventing many race conditions on application stop that could result in zombie processes.

This adds the `application.stop` and `application.restart` actions. It also greatly improves the stability of the stop mechanism, preventing many race conditions on application stop that could result in zombie processes.

blacklight added 18 commits

2023-08-15 11:42:07 +02:00

Using a single constant for DEFAULT_REDIS_QUEUE. 827b564006

Also, catch `AttributeError` on `self._proc.terminate` in the
`HttpBackend`, since the process may already have been terminated and
set to null by another worker process.

s/Application.stop_app/Application.stop/g 1819ee75ef

Moved application argument parser to an external platypush.cli module. 97adc3f775

Added commands module. efef9d7bc0

Added ControllableProcess class. b1f244a812

This class can be used to easily control the execution of underlying
processes.

Added StopCommand and RestartCommand. c89f992867

Added CommandStream class. 06111587f7

This abstraction is used to write and read commands over a UNIX socket.

Added CommandStream to the main Application. 8819a0ed4c

The stream will be used to communicate command messages from the
application to its runner.

Handle KeyboardInterrupt and process return code in the main. c11bc69a66

Added get_default_pid_file utility method. dc1a152433

Added get_remaining_timeout utility function. 7157936b87

Removed redundant Backend._get_redis() method. ceb9d6d1ba

It was used only once, and it could easily be replaced by
`platypush.utils.get_redis()`.

Added wait_stop method to the entities engine and cron scheduler. 04921c759f

Implemented HttpBackend._stop_workers. a8a7ceb2ac

The Tornado WSGI container won't guarantee the termination of the
spawned workers upon termination, so the code of the backend has to take
care of it and terminate all the children processes of the server
process when it terminates.

This also means that `psutil` is now a required base dependency, as we
need to expand the process subtree under the webserver launcher.

Synchronize with the currently running stop thread (if any) in Backend.wait_stop. 46245e851f

Large refactor + stability fixes for the external process control logic. f51beb271e

Added application plugin.

continuous-integration/drone/push Build is failing

Details

00863a176e

Alpine Linux requires the linux-headers package to build psutil.

continuous-integration/drone/push Build is passing

Details

fef6513cc8

blacklight added this to the core project

2023-08-15 11:42:16 +02:00

blacklight self-assigned this

2023-08-15 11:42:21 +02:00

blacklight added the

architecture

enhancement

labels

2023-08-15 11:42:35 +02:00

blacklight changed title from ~~WIP: [#272] Support for external stop/restart control on the application~~ to [#272] Support for external stop/restart control on the application

2023-08-15 21:34:26 +02:00

blacklight merged commit c2a17f0d75 into master

2023-08-15 21:34:44 +02:00

blacklight deleted branch 272/external-proc-controller

2023-08-15 21:34:44 +02:00

blacklight referenced this pull request from a commit

2023-08-15 21:34:46 +02:00

Merge pull request '[#272] Support for external stop/restart control on the application' (#273) from 272/external-proc-controller into master