Better Docker support #277

Merged

blacklight merged 66 commits from 276/better-docker into master 2023-09-04 02:49:15 +02:00

Conversation 0 Commits 66 Files changed 66 +2935 -1394

blacklight commented 2023-08-17 03:06:19 +02:00

Owner

Copy link

Closes: #276

Closes: #276

blacklight added 1 commit 2023-08-17 03:06:19 +02:00

A better Dockerfile. f07b774e75

blacklight added 1 commit 2023-08-17 10:36:01 +02:00

s/--config-file/--config/ option in Dockerfile. 24b04d9103

blacklight added 1 commit 2023-08-17 10:38:28 +02:00

Dockerfile moved to application root afa4de5673

blacklight added 1 commit 2023-08-17 11:26:24 +02:00

Create the default configuration file even if --config is supplied but the file doesn't exist. 657b2cc87d

blacklight added 2 commits 2023-08-18 15:25:57 +02:00

Support for custom key-value overrides on Config.init. ac83b43f98

Added --device_id command line option. ec64b0ef8b

blacklight added 19 commits 2023-08-20 03:39:09 +02:00

Merge branch 'master' into 276/better-docker 0a5fc40dc5

Use sys.executable rather than 'python' to launch the application. e463a52435

Fixed manifest files with outdated formats. c2b3ec8ce3

Pass the database engine to the Alembic process as an extra argument. ... 181da63c89

If the path of the default database engine is overridden via `--workdir`
option then it won't be visible to the new `python` subprocess spawned
for Alembic.

s/Config._cfgfile/Config.config_file/g 5bc82dfe64

Support explicit workdir parameter override in Config constructor. a8836f95f5

Replaced Config.workdir with Config.get_workdir(). ... 1825b492b3

Again, Python < 3.9 doesn't like class properties.

Pass the configuration file used by the application to the Alembic process. ... a8255f3621

The database settings could also be overridden in the configuration file
besides the command line.

We should therefore pass the path to the runtime configuration file, so
the Alembic process can initialize its configuration from the same file
and use the same settings.

Full rewrite of platypush.utils.manifest. ... dd3a701a2e

The new version encapsulates all the utility functions into three
classes - `Manifest`, `Manifests` and `Dependencies`.

s/HttpBackend._DEFAULT_HTTP_PORT/HttpBackend.DEFAULT_HTTP_PORT/g 043f303761

Updated the inspect plugin to the new manifest utils interface. 1cb686bdab

s/logger/_logger/ in the plugins module. ... 69706eaabe

The `logger` name may clash with the context of an action, where
`logger` may have been set to something else.

Tweaked package managers install command arguments. 9002f3034a

Rewritten platydock utility. ... 980af16984

Platydock now will only print out a Dockerfile given a configuration
file.

No more maintaining the state of containers, storing separate workdirs
and configuration directories etc. - that introduced way too much
overhead over Docker.

Updated generate_missing_docs to use the new manifest API. 7889b2f1db

Fixed apt dependencies for mpd plugin. a99ffea37c

Refactored the interface of Platydock and manifest utils. 71c5291190

New way of managing installation scripts and dependencies. ... 199ac5f0f7

Created `platypush/install` folder that contains:

- Dockerfiles for the supported distros
- Lists of required base dependencies for the supported distros
- Install and run scripts
- Added Debian to supported base images

If no configuration file is passed to platydock generate a minimal Dockerfile. 28ba042810

blacklight added 2 commits 2023-08-20 13:34:48 +02:00

Better Dockerfile logic to retrieve sources. ... 5efcae64c1

If the /install folder on the container doesn't contain a copy of the
source files, then the git repository will be cloned under that folder.

The user can specify via `-r/--ref` option which tag/branch/commit they
want to install.

PackageManager has both install and uninstall. a6f8021150

blacklight added 1 commit 2023-08-20 13:49:29 +02:00

Ignore the Dockerfile in the root folder f66c4aa071

blacklight added 15 commits 2023-08-23 11:55:49 +02:00

Added header and footer to generated Dockerfile. 700b8e1d16

Fixed wrong event path in a manifest file. a6752ed034

Remove /var/cache/apk from container image after installation. a28dcb7a8d

Added git a required manifest dependency when needed. ... 2c46b6fe14

It is needed for packages that install pip packages via git.

Added default_os field to PackageManagers enum elements. ... 10c0e5fcad

This is useful to determine which is the default set of scripts that
should be used by the installer depending on the detected installed
package manager.

Refactor/documentation round for platydock. ce68250b4d

Removed legacy platyvenv bash script. ... 782ddf5097

The script is being migrated to a Python implementation.

Added new utility methods to the Dependencies class. 8f39231d31

Dependencies.from_config should include the base system deps. cddf318fa7

Exclude python-* system packages when installing in a venv. 2bff4c9cf1

Added full_command argument to to_pip_install_commands. ... 1ef0d804db

This is useful if we just want to get the list of pip dependencies and
create our own pip command.

Added get_src_root utility function. b10ccdb313

Added PackageManager.get_installed. 449821673c

to_pkg_install_commands should skip already installed sys packages. f230fa79bb

Added new platyvenv Python script. dafd65dc21

blacklight added 1 commit 2023-08-23 20:02:11 +02:00

Clone git repo if platyvenv is not running from a srcdir 9e6430a9ac

blacklight added 1 commit 2023-08-27 23:20:38 +02:00

platyvenv should generate (and document) a run.sh helper script. 86e5f74645

blacklight added 1 commit 2023-08-30 00:06:20 +02:00

Refactored PackageManager classes. ... 429658e7c8

Instead of having a custom `get_installed` callable field, with
replicated code for each package manager, the field has now been
promoted to a class method containing the common logic, and the
instances now expect a `list` field (base command to list the installed
packages using the specified package manager) and a `parse_list_line`
callback field (to extract the base package name given a raw line from
the command above).

Also, we shouldn't run the list command if we're running within a Docker
context - the host and container environments will be different.

blacklight added 2 commits 2023-08-31 02:10:10 +02:00

Refactored Platydock and Platyvenv. ... 4dd713ffd2

The two scripts now share the same command interface, behaviour and base
class.

Also, Platydock now builds a Docker image instead of just printing a
Dockerfile, unless the `--print` option is passed.

Added SIGTERM handler for clean termination in Docker contexts. e6b5abe909

blacklight added 1 commit 2023-08-31 02:12:03 +02:00

Always rebase when pulling from the Github remote. ee955882bf

blacklight added 4 commits 2023-08-31 02:16:30 +02:00

Skip checksum in platypush-git AUR package. ... 0e02e617b3

The master branch can move fast and easily get out of sync with the
released version.

Dockerfile moved to application root 91fde717c9

Dockerfile moved to application root a88b57fff2

Ignore the Dockerfile in the root folder a87a713f5e

blacklight added 1 commit 2023-08-31 02:22:16 +02:00

Try and force push the commits to Github. 867198a092

blacklight added 1 commit 2023-08-31 02:23:31 +02:00

Removed the -f flag from git push. 86ce2647e4

blacklight added 1 commit 2023-08-31 02:33:00 +02:00

(Try and) pull the current branch from Github instead of master. 011f6d3a66

blacklight added 1 commit 2023-08-31 02:34:29 +02:00

Merge branch 'master' into 276/better-docker 1be40f30d6

blacklight added 8 commits 2023-09-04 02:23:52 +02:00

Added utils.is_root method. 9aaf2559fa

gitignore should only skip /config, not any config directories. 5481ae753d

Updated sample nginx configuration. 759075f1d9

Some LINT on the old http.request.rss plugin. 35416f3ee3

LINT/black for tts.mimic3 plugin. 669f2eb2d2

Rewritten the http.webpage plugin. b6c0ff799b

Changed (fixed) default location for config dir if not existing. ... 07c2eee890

Following some common UNIX conventions, if no configuration file is
specified and none exists under the default locations, then a new
configuration directory should be created under:

```
- if root: /etc/platypush
- else:
  - if XDG_CONFIG_HOME:
    - $XDG_CONFIG_HOME/platypush
  - else:
    - ~/.config/platypush
```

Updated default config.yaml. ... c69f97c0a5

The new configuration:

- Enables `backend.http` by default
- Removes the extra `config.auto.yaml` dependency
- Includes many more examples, lots of updates for existing examples,
  and extensive comments.

blacklight added 1 commit 2023-09-04 02:48:02 +02:00

More resilient termination logic for CommandStream. b3c82fe0d1

blacklight merged commit 82ef928d5b into master 2023-09-04 02:49:15 +02:00

blacklight deleted branch 276/better-docker 2023-09-04 02:49:15 +02:00

blacklight referenced this pull request from a commit 2023-09-04 02:49:17 +02:00

Merge pull request 'Better Docker support' (#277) from 276/better-docker into master

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

architecture

  

authentication

  

backend

  

bug

  

ci/cd

  

cleanup

  

documentation

  

duplicate

  

enhancement

  

good first issue

  

help wanted

  

in progress

  

invalid

  

media

  

mobile

  

new feature

  

notes

Tickets about notes plugins

  

packaging

  

question

  

ui

  

upstream breaking change

  

voice

  

waiting user input

  

wontfix

No labels

architecture

authentication

backend

bug

ci/cd

cleanup

documentation

duplicate

enhancement

good first issue

help wanted

in progress

invalid

media

mobile

new feature

notes

packaging

question

ui

upstream breaking change

voice

waiting user input

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

platypush/platypush!277

No description provided.