platypush/platypush
platypush
/
platypush
2
2
Fork 4
Code Issues 44 Pull Requests 1 Packages Projects 4 Releases Wiki Activity

278/fix-variable-errors-on-python-3-8 #279

Merged
blacklight merged 5 commits from 278/fix-variable-errors-on-python-3-8 into master 2023-08-18 17:25:09 +02:00
Conversation 0 Commits 5 Files Changed 4 +38 -30
blacklight commented 2023-08-18 15:54:30 +02:00
Owner
Copy Link

Closes #278

Closes #278
blacklight added the
bug
 label 2023-08-18 15:54:30 +02:00
blacklight self-assigned this 2023-08-18 15:54:30 +02:00
blacklight added 2 commits 2023-08-18 15:54:30 +02:00
5dd7345c0b
Sync the latest parse timestamps in main instead of __init__ in rss. 
We should load the latest timestamps from the db when the thread starts
instead of doing it in the constructor.

The constructor may be invoked when the entities engine hasn't been
initialized yet, and result in deadlocks.
continuous-integration/drone/push Build is passing Details
ca95490412
Added timeout parameter to requests.get in the rss plugin.
blacklight added 3 commits 2023-08-18 17:21:39 +02:00
d0c89f88a8
Fixed parenthesised multi-with statement. 
This syntax is not supported on Python < 3.9, and therefore it should be
broken down as a multi-line statement.
a9cdff900e
_variable should be an external global function rather than a class property. 
The combination of `@property` + `@classmethod` isn't supported on
Python < 3.9.
continuous-integration/drone/push Build is passing Details
2cab836bdf
`Entity.columns` class property replaced by `Entity.get_columns` method. 
Again, Python < 3.9 doesn't like the combination of `@property` +
`@classmethod`.
blacklight changed title from WIP: 278/fix-variable-errors-on-python-3-8 to 278/fix-variable-errors-on-python-3-8 2023-08-18 17:22:46 +02:00
blacklight merged commit 3236e235ef into master 2023-08-18 17:25:09 +02:00
blacklight deleted branch 278/fix-variable-errors-on-python-3-8 2023-08-18 17:25:09 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
architecture

   
bug

   
ci/cd

   
cleanup

   
documentation

   
duplicate

   
enhancement

   
good first issue

   
help wanted

   
in progress

   
invalid

   
new feature

   
packaging

   
question

   
ui

   
waiting user input

   
wontfix
No Label
architecture
bug
ci/cd
cleanup
documentation
duplicate
enhancement
good first issue
help wanted
in progress
invalid
new feature
packaging
question
ui
waiting user input
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
blacklight
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: platypush/platypush#279
No description provided.
Delete Branch "278/fix-variable-errors-on-python-3-8"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?